Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few compiler warnings #1375

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix a few compiler warnings #1375

merged 1 commit into from
Jan 6, 2025

Conversation

jmcarcell
Copy link
Member

BEGINRELEASENOTES

  • Fix a few compiler warnings (clang 18) about:
    • Set but unused variables and unused variables or declarations
    • Deprecated constructor for a Vector3d from a Vector3f from EDM4hep
    • Missing override
    • Having a space after operator"" is deprecated

ENDRELEASENOTES

@jmcarcell
Fix a few compiler warnings about
45be6d8 
- Set but unused variables and unused variables or declarations
- Deprecated constructor for a Vector3d from a Vector3f from EDM4hep
- Missing override
- Having a space after `operator""` is deprecated
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

Test Results

   14 files     14 suites   5h 37m 34s ⏱️
  369 tests   369 ✅ 0 💤 0 ❌
2 538 runs  2 538 ✅ 0 💤 0 ❌

Results for commit 45be6d8.

@MarkusFrankATcernch MarkusFrankATcernch merged commit 874fe28 into AIDASoft:master Jan 6, 2025
15 checks passed
@jmcarcell jmcarcell mentioned this pull request Jan 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarcell @MarkusFrankATcernch